🟡 queueBuild cleanup condition always evaluates to false because it compares next against next.finally(…)

The pendingBuilds map is never cleaned up because the finally callback compares the wrong promise reference. pendingBuilds.set(entryId, next.finally(cb)) stores the new promise returned by .finally(), but inside the callback, the check is this.pendingBuilds.get(entryId) === next — comparing the stored finally-wrapped promise against the original next. Since .finally() always returns a new promise object, this comparison is always false, so pendingBuilds.delete(entryId) never executes.

this.pendingBuilds.set(
    entryId,
    next.finally(() => {
        if (this.pendingBuilds.get(entryId) === next) { // always false
            this.pendingBuilds.delete(entryId);
        }
    }),
);

const wrapped = next.finally(() => {
    if (this.pendingBuilds.get(entryId) === wrapped) {
        this.pendingBuilds.delete(entryId);
    }
});
this.pendingBuilds.set(entryId, wrapped);

Was this helpful? React with 👍 or 👎 to provide feedback.